Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: The default model of VertexAIImagegenerator #158

Conversation

sahusiddharth
Copy link
Contributor

@sahusiddharth sahusiddharth commented Dec 31, 2023

fixes: #151

This PR addresses a discrepancy in the default model used by VertexAIImageGenerator. According to the Vertex AI documentation, the correct default model for image generation is imagegeneration. However, the current default model is set to imagetext, which is designed for image captioning.

Updated the default model for VertexAIImageGenerator to imagegeneration to align with the Vertex AI documentation.

@sahusiddharth sahusiddharth requested a review from a team as a code owner December 31, 2023 07:29
@sahusiddharth sahusiddharth requested review from anakin87 and removed request for a team December 31, 2023 07:29
@anakin87 anakin87 requested review from silvanocerza and removed request for anakin87 January 2, 2024 09:40
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! 🙏

@silvanocerza silvanocerza merged commit 50ae54c into deepset-ai:main Jan 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The default model for VertexAIImageGenerator should be imagegeneration
2 participants