Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chroma DocumentStore creation for pre-existing collection name #157

Merged
merged 3 commits into from
Jan 5, 2024
Merged

fix: Chroma DocumentStore creation for pre-existing collection name #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc15bc1
fix: Error on Chroma DocumentStore creation for pre-existing collecti…
sahusiddharth Dec 31, 2023
766be12
linting done
sahusiddharth Jan 5, 2024
71fb392
Merge branch 'deepset-ai:main' into bug/Chroma-document-store-throws-…
sahusiddharth Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integrations/chroma/src/chroma_haystack/document_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def __init__(
self._embedding_function_params = embedding_function_params
# Create the client instance
self._chroma_client = chromadb.Client()
self._collection = self._chroma_client.create_collection(
self._collection = self._chroma_client.get_or_create_collection(
name=collection_name,
embedding_function=get_embedding_function(embedding_function, **embedding_function_params),
)
Expand Down
5 changes: 5 additions & 0 deletions integrations/chroma/tests/test_document_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ def test_from_json(self):
assert ds._embedding_function == function_name
assert ds._embedding_function_params == {"api_key": "1234567890"}

@pytest.mark.integration
def test_same_collection_name_reinitialization(self):
ChromaDocumentStore("test_name")
ChromaDocumentStore("test_name")

@pytest.mark.skip(reason="Filter on array contents is not supported.")
@pytest.mark.unit
def test_filter_document_array(self, document_store: ChromaDocumentStore, filterable_docs: List[Document]):
Expand Down