fix: make llama.cpp Chat Generator compatible with new ChatMessage
#1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
commented
Dec 18, 2024
Comment on lines
+24
to
+26
| if formatted_msg["role"] == "tool": | ||
| formatted_msg["name"] = message.tool_call_result.origin.tool_name | ||
| formatted_msg["content"] = message.tool_call_result.result |
There was a problem hiding this comment.
starting from 2.9.0, Haystack function messages will be automatically converted to tool messages. This change ensures compatibility.
anakin87
commented
Dec 18, 2024
Comment on lines
+141
to
+145
| if name: | ||
| if hasattr(reply, "_name"): | ||
| reply._name = name # new ChatMessage | ||
| elif hasattr(reply, "name"): | ||
| reply.name = name # legacy ChatMessage |
There was a problem hiding this comment.
once we release 2.9.0, we can get rid of this ugly check
There was a problem hiding this comment.
👍 after 2.9.0 release, we may consider to refactor for's code in a _create_reply method maybe.
mpangrazzi
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
ChatMessage#1249: read the issue for detailsProposed Changes:
ChatMessageHow did you test it?
CI; local tests with Haystack main branch
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.