-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: make nightly tests actually run with Haystack main branch #1251
Conversation
@anakin87 To explicitly install from main, we should use |
@julian-risch I incorporated your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Related Issues
After the release of the new
ChatMessage
in deepset-ai/haystack#8640, I was expecting several failures in the nightly tests with Haystack main.Indeed, I encountered these failures locally by executing the following steps:
However the nightly CI tests did not fail... 🤔
Then I realized what's the difference:
haystack-core-integrations/.github/workflows/amazon_bedrock.yml
Line 84 in 3a3419a
We are not using uv there, so the tests don't run with Haystack main, but with the latest stable release.
Proposed Changes:
How did you test it?
Local tests, CI
Notes for the reviewer
Failing tests are unrelated to this PR
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.