Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix linting/isort #1215

Merged
merged 2 commits into from
Nov 25, 2024
Merged

chore: fix linting/isort #1215

merged 2 commits into from
Nov 25, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Nov 23, 2024 •
edited
Loading

Related Issues

Proposed Changes:

  • fix linting/isort: for each affected integration, I ran hatch env prune + hatch run lint:fmt

How did you test it?

CI

Checklist

@anakin87 anakin87 changed the title fix linting chore: fix linting/isort Nov 23, 2024
anakin87
anakin87 commented Nov 23, 2024
View reviewed changes
integrations/google_vertex/tests/chat/test_gemini.py
@@ -161,13 +161,13 @@ def test_to_dict_with_params(_mock_vertexai_init, _mock_generative_model):
"name": "get_current_weather",
"description": "Get the current weather in a given location",
"parameters": {
"type_": "OBJECT",
"type": "OBJECT",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated. This test has been failing in the last few days.

@anakin87 anakin87 marked this pull request as ready for review November 25, 2024 08:23
@anakin87 anakin87 requested a review from a team as a code owner November 25, 2024 08:23
@anakin87 anakin87 requested review from mpangrazzi and removed request for a team November 25, 2024 08:23
@anakin87 anakin87 merged commit 7b9c8a6 into main Nov 25, 2024
93 checks passed
@anakin87 anakin87 deleted the fix-lint-isort branch November 25, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@mpangrazzi mpangrazzi Awaiting requested review from mpangrazzi mpangrazzi is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
integration:amazon-bedrock integration:chroma integration:cohere integration:fastembed integration:google-ai integration:google-vertex integration:instructor-embedders integration:jina integration:llama_cpp integration:nvidia integration:optimum integration:qdrant integration:weaviate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @silvanocerza