fix: Fastembed - Change default Sparse model as the used one is deprecated due to a typo #1201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the model prithvida/Splade_PP_en_v1 has a typo and is being replaced by prithivida/Splade_PP_en_v1? There's a Deprecation warning about it.
I changed it everywhere in the class & the tests
How did you test it?
Unit tests
Notes for the reviewer
This is changing the behavior if users have not set the model name when creating a FastembedSparseDocumentEmbedder() or FastembedSparseTextEmbedder() as it is the default model in our implementation.
The code in the init on the fastembed side has this code (https://github.com/qdrant/fastembed/blob/main/fastembed/sparse/sparse_text_embedding.py#L58) that raises the deprecation and changes the model.
if model_name == "prithvida/Splade_PP_en_v1":
warnings.warn(
"The right spelling is prithivida/Splade_PP_en_v1. "
"Support of this name will be removed soon, please fix the model_name",
DeprecationWarning,
stacklevel=2,
)
model_name = "prithivida/Splade_PP_en_v1"
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.