Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fastembed - Change default Sparse model as the used one is deprecated due to a typo #1201

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

paulmartrencharpro
Copy link
Contributor

The name of the model prithvida/Splade_PP_en_v1 has a typo and is being replaced by prithivida/Splade_PP_en_v1? There's a Deprecation warning about it.
I changed it everywhere in the class & the tests

How did you test it?

Unit tests

Notes for the reviewer

This is changing the behavior if users have not set the model name when creating a FastembedSparseDocumentEmbedder() or FastembedSparseTextEmbedder() as it is the default model in our implementation.

The code in the init on the fastembed side has this code (https://github.com/qdrant/fastembed/blob/main/fastembed/sparse/sparse_text_embedding.py#L58) that raises the deprecation and changes the model.
if model_name == "prithvida/Splade_PP_en_v1":
warnings.warn(
"The right spelling is prithivida/Splade_PP_en_v1. "
"Support of this name will be removed soon, please fix the model_name",
DeprecationWarning,
stacklevel=2,
)
model_name = "prithivida/Splade_PP_en_v1"

Checklist

…ng replaced by prithivida/Splade_PP_en_v1? There's a Deprecation warning about it.

I changed it everywhere in the class & the tests
@paulmartrencharpro paulmartrencharpro requested a review from a team as a code owner November 19, 2024 16:00
@paulmartrencharpro paulmartrencharpro requested review from Amnah199 and removed request for a team November 19, 2024 16:00
@github-actions github-actions bot added integration:fastembed type:documentation Improvements or additions to documentation labels Nov 19, 2024
@anakin87 anakin87 self-requested a review November 19, 2024 16:01
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@anakin87 anakin87 merged commit 8755e4a into deepset-ai:main Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:fastembed type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants