Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improvements to NvidiaRanker and adding user input timeout #1193

Merged
merged 16 commits into from
Nov 21, 2024
Merged

feat: Improvements to NvidiaRanker and adding user input timeout #1193

merged 16 commits into from
Nov 21, 2024

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Nov 14, 2024 •
edited
Loading

Related Issues

  • fixes #issue-number

Proposed Changes:

  • Adds user specifiable timeout. Previously hard coded to 60 seconds.
  • Improves the NvidiaRanker to have the same feature set as other rankers in Haystack (e.g. meta_fields_to_embed)
  • Adds more logging statements

How did you test it?

  • added and updated tests

Notes for the reviewer

Checklist

@github-actions github-actions bot added integration:nvidia type:documentation Improvements or additions to documentation labels Nov 14, 2024
@sjrl sjrl marked this pull request as ready for review November 15, 2024 15:48
@sjrl sjrl requested a review from a team as a code owner November 15, 2024 15:48
@sjrl sjrl requested review from vblagoje and removed request for a team November 15, 2024 15:48
@sjrl sjrl requested review from davidsbatista and removed request for vblagoje November 15, 2024 15:58
@sjrl sjrl requested a review from davidsbatista November 21, 2024 07:29
davidsbatista
davidsbatista approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjrl sjrl merged commit 16bc80f into main Nov 21, 2024
10 checks passed
@sjrl sjrl deleted the nvidia-settable-timeout branch November 21, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

Assignees
No one assigned
Labels
integration:nvidia type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjrl @davidsbatista