Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deepeval - pin indirect dependencies based on python version #1187

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Nov 13, 2024

Related Issues

Proposed Changes:

  • pin langchain dependency for python 3.9

How did you test it?

CI

Notes for the reviewer

In the long run, I would like to unpin deepeval and support more recent versions,
but it's not trivial (we haven't done that for a while).

Checklist

@anakin87 anakin87 changed the title try pinning pydantic in deepeval fix: deepeval - pin indirect dependencies based on python version Nov 13, 2024
@anakin87 anakin87 marked this pull request as ready for review November 13, 2024 09:57
@anakin87 anakin87 requested a review from a team as a code owner November 13, 2024 09:57
@anakin87 anakin87 requested review from shadeMe and silvanocerza and removed request for a team November 13, 2024 09:57
@anakin87 anakin87 merged commit ee4ca75 into main Nov 14, 2024
10 checks passed
@anakin87 anakin87 deleted the try-fixing-deepeval branch November 14, 2024 09:48
Amnah199 pushed a commit to ttmenezes/haystack-core-integrations that referenced this pull request Nov 15, 2024
…epset-ai#1187)

* try pinning pydantic

* retry

* again

* more precise pin

* fix

* better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants