Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nvidia/llama-3.2-nv-rerankqa-1b-v1 to set of known ranking models #1183

Merged

Conversation

mattf
Copy link
Contributor

@mattf mattf commented Nov 12, 2024

Related Issues

n/a

Proposed Changes:

add a new model

How did you test it?

ran existing tests w/ default model changed to this new model

Notes for the reviewer

n/a

Checklist

@mattf mattf requested a review from a team as a code owner November 12, 2024 18:52
@mattf mattf requested review from Amnah199 and removed request for a team November 12, 2024 18:52
@anakin87 anakin87 merged commit a221ad5 into deepset-ai:main Nov 13, 2024
10 checks passed
@d-kleine
Copy link

d-kleine commented Dec 23, 2024

As it seems like NVIDIA is adding some more models (e.g. nvidia/llama-3.2-nv-rerankqa-1b-v2) to v1/retrieval, I think it would be a better idea to add this url path to


so that either v1/ranking or v1/retrieval (this also uses a /reranking suffix) can pass the url path check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants