fix: VertexAIGeminiGenerator - remove support for tools and change output type
#1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:google-vertex
type:documentation
anakin87
requested review from
vblagoje and
silvanocerza
and removed request for
a team
silvanocerza
approved these changes
Nov 14, 2024
Amnah199
pushed a commit
to ttmenezes/haystack-core-integrations
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
GoogleAIGeminiGenerator- remove support for tools and change output type #1177We are removing support for tools in order to produce a
List[str]output type, for consistency with other generators.Users interested in tool calling should use the corresponding Chat Generator.
Proposed Changes:
List[str]How did you test it?
CI
Notes for the reviewer
This is a breaking change and I will release a major version.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.