feat: Add BM25 and Hybrid Search Retrievers to Azure AI Search Integration #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
type:documentation
ttmenezes
changed the title
ttmenezes
changed the title
Amnah199
reviewed
Nov 15, 2024
..._ai_search/src/haystack_integrations/components/retrievers/azure_ai_search/bm25_retriever.py
Show resolved
Hide resolved
Enable kwargs for semantic ranking in retrievers
Amnah199
approved these changes
Nov 18, 2024
julian-risch
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Looks quite good to me already. I have a couple of very small change requests. Another suggestion for improvement would be to cover the run method with a unit test and mock for example _bm25_retrieval. The test could check that _bm25_retrieval is called with the expected parameters. Similarly for the hybrid retriever.
..._ai_search/src/haystack_integrations/components/retrievers/azure_ai_search/bm25_retriever.py
Outdated
Show resolved
Hide resolved
...i_search/src/haystack_integrations/components/retrievers/azure_ai_search/hybrid_retriever.py
Outdated
Show resolved
Hide resolved
...i_search/src/haystack_integrations/components/retrievers/azure_ai_search/hybrid_retriever.py
Show resolved
Hide resolved
...i_search/src/haystack_integrations/components/retrievers/azure_ai_search/hybrid_retriever.py
Show resolved
Hide resolved
...i_search/src/haystack_integrations/components/retrievers/azure_ai_search/hybrid_retriever.py
Outdated
Show resolved
Hide resolved
..._ai_search/src/haystack_integrations/components/retrievers/azure_ai_search/bm25_retriever.py
Show resolved
Hide resolved
..._ai_search/src/haystack_integrations/components/retrievers/azure_ai_search/bm25_retriever.py
Outdated
Show resolved
Hide resolved
..._ai_search/src/haystack_integrations/components/retrievers/azure_ai_search/bm25_retriever.py
Show resolved
Hide resolved
.../azure_ai_search/src/haystack_integrations/document_stores/azure_ai_search/document_store.py
Show resolved
Hide resolved
…nts/retrievers/azure_ai_search/bm25_retriever.py Co-authored-by: Julian Risch <[email protected]>
julian-risch
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Looks good to me! 👍
Edit: I talked to @Amnah199 offline about adding unit tests for the run methods.
julian-risch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
This PR includes the following features:
How did you test it?
Notes for the reviewer
Used the existing embedding retriever code as a template and primarily just changed the parameters in the calls to the Azure AI Search Python SDK.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.