-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow passing boto3 config to all AWS Bedrock classes #1166
fix: Allow passing boto3 config to all AWS Bedrock classes #1166
Conversation
@davidsbatista I could not completely sign the CLA because I accidentaly some of the commits without configuring my email address. Should I leave it like this or is it okay to update the author of those commits and force-push the change? |
You need to sign the CLA in order for the PR to be merged, so it seems you will need to update the author of these commits. |
@AnesBenmerzoug thanks for this contribution! I've left some comments regarding backward compatibility. I've also asked my colleague @vblagoje to do a second review. |
…eepset-ai#1165) * fix chroma breaking changes * improve warning * better warning
b59e51a
to
f08beea
Compare
@AnesBenmerzoug remove the parameterization of all the tests, and instead do a test such that:
|
@davidsbatista Sorry for the delay. I am not quite sure I understand your suggestion. I believe the tests with the parametrization already test the serialization and deserialization of the different bedrock instances with and without the boto3 config. Could you please explain what you meant more clearly? |
sorry, this was a misunderstanding from my side - I think we could remove that parameterization but it doesn't hurt to be there. I've approved your PR - you just need to sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@davidsbatista Thanks! I have already signed the CLA. |
Related PR
Proposed Changes:
boto3_config
dictionary and use it when initializing boto3 client.How did you test it?
hatch test
Notes for the reviewer
This is a follow up to PR !1135 that simply applies the same change to all other aws bedrock classes (
AmazonBedrockDocumentEmbedder
,AmazonBedrockTextEmbedder
,AmazonBedrockChatGenerator
).Checklist
I have updated the related issue with new insights and changesfix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.