fix: adapt our implementation to breaking changes in Chroma 0.5.17 #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:chroma
type:documentation
anakin87
requested review from
Amnah199 and
davidsbatista
and removed request for
a team
Amnah199
reviewed
Nov 4, 2024
integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py
Outdated
Show resolved
Hide resolved
AnesBenmerzoug
pushed a commit
to AnesBenmerzoug/haystack-core-integrations
that referenced
this pull request
Nov 14, 2024
…eepset-ai#1165) * fix chroma breaking changes * improve warning * better warning
davidsbatista
added a commit
that referenced
this pull request
Dec 3, 2024
* Allow passing boto3 config to AmazonBedrockChatGenerator * Allow passing boto3 config to AmazonBedrockDocumentEmbedder * Allow passing boto3 config to AmazonBedrockTextEmbedder * Remove whitespace from blank line * Reorder setting attributes for readability * Remove blank line * fix: adapt our implementation to breaking changes in Chroma 0.5.17 (#1165) * fix chroma breaking changes * improve warning * better warning * Update the changelog * Parametrize to_dict and from_dict tests with boto3_config --------- Co-authored-by: Stefano Fiorucci <[email protected]> Co-authored-by: HaystackBot <[email protected]> Co-authored-by: David S. Batista <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
None) causes an error{}toNoneProposed Changes:
chroma>=0.5.17How did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.