-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add JinaReaderConnector
#1150
Conversation
Ag branch
Hi @anakin87, @Anitha6g and I were trying to think of the best way to handle returning the output of the tool. The unfortunate thing is that it is all markdown and not structured. Should we parse the content and put those things in doc metadata? Thoughts? |
Let me have a look ⌛ |
I'm finally back, after doing a deeper investigation 🕵️ and discussing this with @bilgeyucel.
Let me know what you think. I am quite convinced about the plan, even if it requires some work. |
@anakin87 @bilgeyucel great points, will get right on it and rebase in a couple days. Thanks for the direction as always 😎 |
Very nice @jlonge4 , I wanted to use such a component. |
@vblagoje thanks very much! Still have to whip up those tests but should be done(ish) today 🤞🏼 |
@jlonge4 the circular import error should be fixed now. |
@anakin87 how are we looking? |
@jlonge4 in the coming days, I will take a proper look, so as to push this to the finish line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the code a bit, added more tests and an example.
This is ready to be merged now.
We may need help with other stuff related to this integration.
Let's sync in #663!
Related Issues
Proposed Changes:
Implement the Jina AI Reader as a haystack component
How did you test it?
Manual Verification
Notes for the reviewer
N/A
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.