Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing Chroma tests due chromadb update behaviour change #1148

Merged
merged 7 commits into from
Oct 18, 2024
Merged

fix: fixing Chroma tests due chromadb update behaviour change #1148

merged 7 commits into from
Oct 18, 2024

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Oct 18, 2024 •
edited
Loading

Related Issues

Proposed Changes:

  • Updated the tests
    • Removed the tests that override inequality tests from FilterDocumentsTest since now documents with None metadata are returned
    • Updated the filterable_documents fixture inside the test_multiple_contains since now documents with content=None are not returned

How did you test it?

  • locally run the unit tests and integration tests
  • manual verification
  • CI tests

Checklist

@davidsbatista davidsbatista requested a review from a team as a code owner October 18, 2024 11:49
@davidsbatista davidsbatista requested review from anakin87 and removed request for a team October 18, 2024 11:49
@davidsbatista davidsbatista marked this pull request as draft October 18, 2024 11:56
@anakin87 anakin87 requested a review from Amnah199 October 18, 2024 15:11
@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Oct 18, 2024
@davidsbatista davidsbatista changed the title initial import fix: fixing Chroma tests due chromadb update behaviour change Oct 18, 2024
@davidsbatista davidsbatista marked this pull request as ready for review October 18, 2024 15:35
anakin87
anakin87 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Amnah199
Copy link
Contributor

👍

@davidsbatista davidsbatista merged commit 61ac2f4 into main Oct 18, 2024
13 checks passed
@davidsbatista davidsbatista deleted the fix-multiple-contains-failing-test branch October 18, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

@Amnah199 Amnah199 Awaiting requested review from Amnah199

Assignees
No one assigned
Labels
integration:chroma type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chroma test_multiple_contains is failing
3 participants
@davidsbatista @Amnah199 @anakin87