feat: efficient knn filtering support for OpenSearch #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:opensearch
type:documentation
tstadel
changed the title
|
|
||
| filters = {"field": "meta_field", "operator": "==", "value": "custom_value"} | ||
| # we set top_k=3, to make the test pass as we are not sure whether efficient filtering is supported for nmslib | ||
| # TODO: remove top_k=3, when efficient filtering is supported for nmslib |
There was a problem hiding this comment.
It doesn't seem necessary for this test already, I tried running it locally without setting top_k and it passed.
tstadel
commented
Oct 29, 2024
silvanocerza
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.