feat: add prefixes to supported model patterns to allow cross region model ids #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
integration:amazon-bedrock
type:documentation
abrahamy
changed the title
|
This recent contribution seems related: #1120 |
shadeMe
suggested changes
Oct 8, 2024
...s/amazon_bedrock/src/haystack_integrations/components/generators/amazon_bedrock/generator.py
Outdated
Show resolved
Hide resolved
...s/amazon_bedrock/src/haystack_integrations/components/generators/amazon_bedrock/generator.py
Outdated
Show resolved
Hide resolved
shadeMe
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Expands the regular expression used to select specific adapters by model id name to support models that are cross region. In general, model ids take on a
us.oreu.prefix when used across regions.How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.