Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unpin llama-cpp-python #1115

Merged
merged 10 commits into from
Sep 30, 2024
Merged

chore: unpin llama-cpp-python #1115

merged 10 commits into from
Sep 30, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Sep 30, 2024

Related Issues

Proposed Changes:

  • make the hanging test run in a reasonable amount of time
    • force the choice of the tool (as shown in the docs)
    • also set n_ctx to 512 (default in llama-cpp-python, while the default in our integration is 0 = inferred from the model)
  • unpin llama-cpp-python

How did you test it?

CI

Notes for the reviewer

I think in the future we will rework function calling with llama-cpp-python and remove the test with this model (functionary-small-v2.4), which is becoming obsolete.
In the meantime, I prefer to try to be compatible with the latest versions of this library.

Checklist

@anakin87 anakin87 changed the title unpin llamacpp chore: unpin llama-cpp-python Sep 30, 2024
@anakin87 anakin87 self-assigned this Sep 30, 2024
@anakin87 anakin87 marked this pull request as ready for review September 30, 2024 16:25
@anakin87 anakin87 requested a review from a team as a code owner September 30, 2024 16:25
@anakin87 anakin87 requested review from julian-risch and removed request for a team September 30, 2024 16:25
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@anakin87 anakin87 merged commit 97094f7 into main Sep 30, 2024
11 checks passed
@anakin87 anakin87 deleted the unpin-llama-cpp branch September 30, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants