-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Snowflake integration #1064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @medsriha!
I left a few comments, nothing big.
Regarding the tests please add serialization/deserialization of a pipeline with this component on it, see here an example: https://github.com/deepset-ai/haystack-core-integrations/blob/main/integrations/google_vertex/tests/test_gemini.py#L261
...s/snowflake/src/haystack_integrations/components/retrievers/snowflake/snowflake_retriever.py
Outdated
Show resolved
Hide resolved
...s/snowflake/src/haystack_integrations/components/retrievers/snowflake/snowflake_retriever.py
Outdated
Show resolved
Hide resolved
...s/snowflake/src/haystack_integrations/components/retrievers/snowflake/snowflake_retriever.py
Outdated
Show resolved
Hide resolved
Thank you for reviewing this, @davidsbatista. I have also updated the object name from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* initial commit * add unit tests * add pyproject.toml * add pydoc config * add CHANGELOG file * update pyproject.toml * lint file * add example and fix lint * update comments * add header and trailing line * update based on review
Related Issues
Proposed Changes:
Component that connects to a Snowflake database and retrieves data using a SQL query. This integration could be used standalone like such:
Or within a pipeline for a text2SQL task, for example. See the attached example for reference.
Missing items:
snowflake.md
to haystack-integrationsHow did you test it?
unit tests
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.