Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update opensearch retriever docstrings #1035

Merged

Conversation

kanenorman
Copy link
Contributor

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@kanenorman kanenorman requested a review from a team as a code owner August 29, 2024 00:52
@kanenorman kanenorman requested review from julian-risch and removed request for a team August 29, 2024 00:52
@CLAassistant
Copy link

CLAassistant commented Aug 29, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added integration:opensearch type:documentation Improvements or additions to documentation labels Aug 29, 2024
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me! 👍 Thank you @kanenorman and congratulations on your first contribution to Haystack!

@julian-risch julian-risch merged commit 32f3ffb into deepset-ai:main Aug 29, 2024
8 checks passed
@kanenorman kanenorman deleted the update-opensearch-retriever-docstrings branch August 29, 2024 13:33
Amnah199 pushed a commit that referenced this pull request Oct 2, 2024
* docs: Update OpenSearchBM25Retriever metadata filter syntax

* docs: Update OpenSearchEmbeddingRetriever metadata filter syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:opensearch type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opensearch retrievers docstrings show the old filters syntax
3 participants