Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chat roles for model responses in chat generators #1030

Merged
merged 5 commits into from
Aug 30, 2024
Merged

fix: chat roles for model responses in chat generators #1030

merged 5 commits into from
Aug 30, 2024

Conversation

Amnah199
Copy link
Contributor

Related Issues

Proposed Changes:

  • Updated the role assigned to model responses from system to assistant for both GoogleGeminiChatGenerator and VertexAIGeminiChatGenerator.
  • Reviewed and verified consistency across other generators to ensure correct role assignment.

How did you test it?

Ran existing tests

Notes for the reviewer

Checklist

@Amnah199 Amnah199 requested a review from anakin87 August 27, 2024 14:15
@Amnah199 Amnah199 marked this pull request as ready for review August 27, 2024 14:15
@Amnah199 Amnah199 requested a review from a team as a code owner August 27, 2024 14:15
@Amnah199 Amnah199 requested review from silvanocerza and removed request for a team and silvanocerza August 27, 2024 14:15
anakin87
anakin87 reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please also update these other occurrences

wrong usage example:

haystack-core-integrations/integrations/ollama/examples/chat_generator_example.py

Line 14 in 3b05662

ChatMessage.from_system(

wrong tests:

haystack-core-integrations/integrations/amazon_bedrock/tests/test_chat_generator.py

Line 203 in 3b05662

messages = [ChatMessage.from_system("What is the biggest city in United States?")]

haystack-core-integrations/integrations/google_ai/tests/generators/chat/test_chat_gemini.py

Line 260 in 3b05662

ChatMessage.from_system(content="It's an arithmetic operation."),

@Amnah199 Amnah199 marked this pull request as draft August 27, 2024 14:31
@Amnah199 Amnah199 marked this pull request as ready for review August 27, 2024 17:04
@Amnah199 Amnah199 requested a review from anakin87 August 27, 2024 17:54
anakin87
anakin87 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Feel free to merge.

Having more tests would help.
See #1019 (comment)

integrations/google_ai/src/haystack_integrations/components/generators/google_ai/chat/gemini.py Show resolved Hide resolved
@Amnah199 Amnah199 merged commit e1c0fc3 into main Aug 30, 2024
25 checks passed
@Amnah199 Amnah199 deleted the fix-role-chat-gen branch August 30, 2024 09:13
Amnah199 added a commit that referenced this pull request Oct 2, 2024
@Amnah199
fix: chat roles for model responses in chat generators (#1030)
d7926a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees
No one assigned
Labels
integration:amazon-bedrock integration:google-ai integration:google-vertex integration:ollama
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check ChatRoles in responses returned by ChatGenerators
2 participants
@Amnah199 @anakin87