fix unused imports and mypy

deepset-ai · Nov 30, 2023 · 79f1127 · 79f1127
1 parent 829a9bb
commit 79f1127
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/integrations/opensearch/pyproject.toml b/integrations/opensearch/pyproject.toml
@@ -11,7 +11,7 @@ requires-python = ">=3.8"
 license = "Apache-2.0"
 keywords = []
 authors = [
-  { name = "Silvano Cerza", email = "[email protected]" },
+  { name = "deepset", email = "[email protected]" },
 ]
 classifiers = [
   "Development Status :: 4 - Beta",
@@ -172,6 +172,7 @@ markers = [
 [[tool.mypy.overrides]]
 module = [
   "haystack.*",
-  "pytest.*"
+  "pytest.*",
+  "opensearchpy.*",
 ]
 ignore_missing_imports = true
diff --git a/integrations/opensearch/src/opensearch_haystack/document_store.py b/integrations/opensearch/src/opensearch_haystack/document_store.py
@@ -2,16 +2,15 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 import logging
-from typing import Any, Dict, List, Literal, Mapping, Optional, Union
+from typing import Any, Dict, List, Mapping, Optional, Union
 
 import numpy as np
-
-from opensearchpy import OpenSearch, Urllib3HttpConnection, RequestsHttpConnection, NotFoundError, RequestError
-from opensearchpy.helpers import bulk, scan
 from haystack import default_from_dict, default_to_dict
 from haystack.dataclasses import Document
 from haystack.document_stores import DocumentStoreError, DuplicateDocumentError, DuplicatePolicy, document_store
 from haystack.utils.filters import convert
+from opensearchpy import OpenSearch
+from opensearchpy.helpers import bulk
 
 from opensearch_haystack.filters import _normalize_filters
 
@@ -63,7 +62,7 @@ def __init__(
         embedding_dim = kwargs.get("embedding_dim", 768)
         method = kwargs.get("method", None)
 
-        mappings = {
+        mappings: Dict[str, Any] = {
             "properties": {
                 "embedding": {"type": "knn_vector", "index": True, "dimension": embedding_dim},
                 "content": {"type": "text"},

diff --git a/integrations/opensearch/tests/test_document_store.py b/integrations/opensearch/tests/test_document_store.py
@@ -7,11 +7,11 @@
 from unittest.mock import patch
 
 import pytest
-from opensearchpy.exceptions import RequestError  # type: ignore[import-not-found]
 from haystack.dataclasses.document import Document
 from haystack.document_stores.errors import DocumentStoreError, DuplicateDocumentError
 from haystack.document_stores.protocols import DuplicatePolicy
 from haystack.testing.document_store import DocumentStoreBaseTests
+from opensearchpy.exceptions import RequestError  # type: ignore[import-not-found]
 
 from opensearch_haystack.document_store import OpenSearchDocumentStore