Add basic action to run current tests #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lizing pipelines)
mpangrazzi
changed the title
anakin87
reviewed
Dec 19, 2024
.github/workflows/tests.yml
Outdated
| run: pip install hatch==${{ env.HATCH_VERSION }} | ||
|
|
||
| - name: Run unit and integration tests | ||
| run: hatch run test:all |
There was a problem hiding this comment.
I would suggest to also run and report coverage.
These commands can serve as examples: https://github.com/deepset-ai/haystack-core-integrations/blob/4f067b9b183020d039be017990eb7f868e116099/integrations/amazon_bedrock/pyproject.toml#L53
Even if the report is only visible in GitHub Actions, it is still inspectable
An example: https://github.com/deepset-ai/haystack-core-integrations/actions/runs/12397435961/job/34607798450?pr=1255
There was a problem hiding this comment.
yeah, I was planning to add it later, but we can run test:cov here to get both tests and cov output.
anakin87
approved these changes
Dec 19, 2024
Co-authored-by: Stefano Fiorucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this I am adding a basic action to run tests on Python
3.9-3.12(I've removed3.7-3.8support which was present inpyproject.toml).