Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rows #115

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Add rows #115

merged 11 commits into from
Nov 22, 2024

Conversation

sg-s
Copy link
Collaborator

@sg-s sg-s commented Nov 21, 2024

changes

  • loc indexer should disallow adding new rows to a DF
  • ability to modify existing rows using loc
  • from_deeporigin now works with completely empty DBs
  • from_deeporigin now works with DBs with no rows (but some columns)
  • tests: ability to modifiy 1 row using .loc
  • tests: ability to modify many rows using .loc
  • tests: prevention of adding new rows to a DF
  • support for appending a square chunk (similar to a DB) directly to a DB. combination of create new rows + write data
  • support for writing 1 new row to a DB with all columns with data
  • support for writing many rows + many columns
  • documentation explaining how to add new rows to a DB

@sg-s sg-s requested a review from a team as a code owner November 21, 2024 03:06
@sg-s sg-s self-assigned this Nov 21, 2024
Copy link
Contributor

@kennyjwilli kennyjwilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd lean more towards a row-centric add method, but if you think column centric is more pythonic, let's do that.

docs/how-to/data-hub/add-data.md Outdated Show resolved Hide resolved
src/data_hub/api.py Outdated Show resolved Hide resolved
src/data_hub/api.py Show resolved Hide resolved
docs/how-to/data-hub/add-data.md Show resolved Hide resolved
@sg-s
Copy link
Collaborator Author

sg-s commented Nov 22, 2024

I'd lean more towards a row-centric add method, but if you think column centric is more pythonic, let's do that.

@kennyjwilli not sure what you mean? it kinda is row centric in that you get to add rows.

@sg-s sg-s enabled auto-merge (squash) November 22, 2024 17:17
@sg-s sg-s merged commit b546456 into main Nov 22, 2024
13 checks passed
@sg-s sg-s deleted the add-rows branch November 22, 2024 17:17
@kennyjwilli
Copy link
Contributor

I'd lean more towards a row-centric add method, but if you think column centric is more pythonic, let's do that.

@kennyjwilli not sure what you mean? it kinda is row centric in that you get to add rows.

You pass in columns first instead of rows. Personally, I find passing rows first much easier to work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants