Refactor of test stack #114

sg-s · 2024-11-18T20:54:46Z

changes

see comments inline

problem description

our underlying stainless-generated code returned responses as objects. this was problematic because:

sometimes these pydantic models would fail to model_dump
this introduced a dependence on these models
tests became more complex because mock client needed to recreate all these objects

solution

switch to only dealing with dicts
overhaul the mock client to directly read from a stash of responses from the live client

Makefile

pyproject.toml

src/cli/data.py

src/data_hub/_api.py

pyproject.toml

src/cli/data.py

src/data_hub/api.py

tests/test_data_hub.py

tests/test_cli_config.py

tests/mock_client.py

src/utils/types.py

src/utils/core.py

kennyjwilli

This looks like a huge win wrt simplification. Hopefully you got all the snake -> camel cases! Let's test 🚢

src/cli/data.py

src/data_hub/_api.py

src/data_hub/api.py

src/data_hub/filters.py

tests/fixtures/responses/create_database.json

tests/test_cli_config.py

sg-s added 4 commits November 18, 2024 11:26

feat: major refactor of tests (ongoing)

5e856d7

fix: all tests pass on live on datahub

46035d2

fix: inching towards tests passing

6a10ecb

fix: use tempfile

5eaa902

sg-s requested a review from a team as a code owner November 18, 2024 20:54

sg-s self-assigned this Nov 18, 2024

fix: cli tests pass

ec02844

sg-s commented Nov 18, 2024

View reviewed changes

Makefile Show resolved Hide resolved

Makefile Show resolved Hide resolved

pyproject.toml Show resolved Hide resolved

src/cli/data.py Show resolved Hide resolved

src/data_hub/_api.py Show resolved Hide resolved

src/data_hub/_api.py Outdated Show resolved Hide resolved

sg-s added 5 commits November 18, 2024 19:36

fix: tests pass with CLI

fe8a94e

fix: all tests pass now

551f793

fix: all tests pass

713680f

fix: cleaned up some commented out code

6aae338

fix: sanitized some responses

5642502

sg-s commented Nov 19, 2024

View reviewed changes

tests/test_data_hub.py Show resolved Hide resolved

tests/test_data_hub.py Show resolved Hide resolved

tests/test_cli_config.py Show resolved Hide resolved

tests/mock_client.py Outdated Show resolved Hide resolved

sg-s added 3 commits November 19, 2024 09:17

fix: ability to write more than 1000 rows to a DB

5934fe7

fix: removed unused import

b574c46

fix: all tests now pass on live instance

36dcd4e

sg-s commented Nov 19, 2024

View reviewed changes

src/utils/types.py Show resolved Hide resolved

src/utils/core.py Show resolved Hide resolved

src/utils/core.py Show resolved Hide resolved

kennyjwilli approved these changes Nov 19, 2024

View reviewed changes

sg-s merged commit bef6e71 into main Nov 19, 2024
12 checks passed

sg-s deleted the 11-15-filtering branch November 19, 2024 18:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor of test stack #114

Refactor of test stack #114

sg-s commented Nov 18, 2024 •

edited

Loading

kennyjwilli left a comment

Refactor of test stack #114

Refactor of test stack #114

Conversation

sg-s commented Nov 18, 2024 • edited Loading

changes

problem description

solution

kennyjwilli left a comment

Choose a reason for hiding this comment

sg-s commented Nov 18, 2024 •

edited

Loading