-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix spelling PRECISON -> PRECISION #4508
Conversation
Luckily, this variable has never been used otherwhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 17 changed files in this pull request and generated no comments.
Files not reviewed (12)
- deepmd/pt/model/model/make_model.py: Evaluated as low risk
- deepmd/pd/infer/deep_eval.py: Evaluated as low risk
- deepmd/pt/infer/deep_eval.py: Evaluated as low risk
- deepmd/dpmodel/model/make_model.py: Evaluated as low risk
- deepmd/pd/model/descriptor/se_t_tebd.py: Evaluated as low risk
- deepmd/pd/model/model/make_model.py: Evaluated as low risk
- deepmd/pt/model/descriptor/se_t.py: Evaluated as low risk
- deepmd/pt/model/descriptor/se_a.py: Evaluated as low risk
- deepmd/pd/model/descriptor/se_a.py: Evaluated as low risk
- deepmd/pt/model/descriptor/se_t_tebd.py: Evaluated as low risk
- deepmd/pt/model/descriptor/se_r.py: Evaluated as low risk
- deepmd/pd/model/descriptor/dpa1.py: Evaluated as low risk
📝 WalkthroughWalkthroughThis pull request focuses on correcting a spelling error in the variable name Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (17)
✅ Files skipped from review due to trivial changes (16)
🔇 Additional comments (3)deepmd/pt/utils/env.py (3)
Correcting the spelling of the variable here to
This assertion ensures type safety by verifying that every value in
Adding Run this script to confirm there are no remaining references to the old spelling: ✅ Verification successfulNo misspelled references found, variable is used consistently The search results confirm that:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Searching for any leftover references to the misspelled variable across the entire codebase
rg -A 3 'RESERVED_PRECISON_DICT'
Length of output: 32 Script: #!/bin/bash
# Let's verify both the old and new spellings to ensure the change was made correctly
echo "Checking for RESERVED_PRECISION_DICT (correct spelling):"
rg -A 3 'RESERVED_PRECISION_DICT'
echo -e "\nChecking files containing precision-related constants:"
fd -e py | xargs grep -l "precision" || true
Length of output: 18210 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #4508 +/- ##
==========================================
- Coverage 84.59% 84.58% -0.01%
==========================================
Files 675 675
Lines 63574 63575 +1
Branches 3490 3486 -4
==========================================
Hits 53778 53778
- Misses 8670 8671 +1
Partials 1126 1126 ☔ View full report in Codecov by Sentry. |
Luckily, this variable has never been used otherwhere.
Summary by CodeRabbit
Bug Fixes
RESERVED_PRECISON_DICT
toRESERVED_PRECISION_DICT
across multiple files to ensure consistency and prevent potential runtime errors.Documentation