-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix the header of the scaling test table #4507
docs: fix the header of the scaling test table #4507
Conversation
Fix deepmodeling#4494. Signed-off-by: Jinzhe Zeng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
📝 WalkthroughWalkthroughThe pull request updates the documentation for parallel training in the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
doc/train/parallel-training.md (1)
32-37
: Consider standardizing decimal places in the results.The table structure and headers are now clear and well-organized. However, for better readability, consider standardizing the decimal places:
| Num of GPU cards | Samples per batch | Seconds every 100 batches | Samples per second | Speed up | | ---------------- | ----------------- | ------------------------- | ------------------ | -------- | -| 1 | 1 | 1.4515 | 68.89 | 1.00 | -| 2 | 2 | 1.5962 | 62.65\*2 | 1.82 | -| 4 | 4 | 1.7635 | 56.71\*4 | 3.29 | -| 8 | 8 | 1.7267 | 57.91\*8 | 6.72 | +| 1 | 1 | 1.452 | 68.89 | 1.00 | +| 2 | 2 | 1.596 | 62.65\*2 | 1.82 | +| 4 | 4 | 1.764 | 56.71\*4 | 3.29 | +| 8 | 8 | 1.727 | 57.91\*8 | 6.72 |
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
doc/train/parallel-training.md
(1 hunks)
🔇 Additional comments (1)
doc/train/parallel-training.md (1)
30-31
: LGTM! Clear explanation of batch size configuration.
The added context about batch size per GPU card improves clarity and helps readers understand the scaling test results better.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #4507 +/- ##
==========================================
- Coverage 84.59% 84.58% -0.01%
==========================================
Files 675 675
Lines 63574 63575 +1
Branches 3490 3486 -4
==========================================
Hits 53778 53778
- Misses 8670 8671 +1
Partials 1126 1126 ☔ View full report in Codecov by Sentry. |
Fix #4494.
Summary by CodeRabbit