fix: print dlerror if dlopen fails

[njzjz]

xref: njzjz/deepmd-gnn#44

Summary by CodeRabbit

• New Features

  • Enhanced error messages for library loading failures on non-Windows platforms.
  • Updated thread management environment variable checks for improved compatibility.
  • Added support for mixed types in tensor input handling, allowing for more flexible configurations.

• Bug Fixes

  • Improved error reporting for dynamic library loading issues.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)

• source/api_cc/src/common.cc: Language not supported
• source/lib/src/gpu/cudart/cudart_stub.cc: Language not supported

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces enhancements to error handling and compatibility in two source files: common.cc and cudart_stub.cc. The changes focus on improving error messages during library loading, extending environment variable checks for thread management, and adding more flexible tensor input handling. These modifications aim to provide more informative error reporting and better support for different runtime configurations in the deepmd framework.

Changes

File	Change Summary
source/api_cc/src/common.cc	- Enhanced _load_library_path error messages with dlerror() output - Updated get_env_nthreads to check additional TensorFlow and OpenMP environment variables - Extended session_input_tensors functions with new overloads for mixed type handling
source/lib/src/gpu/cudart/cudart_stub.cc	- Added detailed error message using dlerror() for non-Windows platforms when library loading fails

Sequence Diagram

sequenceDiagram
    participant App as Application
    participant Common as Common Module
    participant Env as Environment
    
    App->>Common: Request thread configuration
    Common->>Env: Check environment variables
    Env-->>Common: Return thread settings
    alt No specific thread variables set
        Common->>App: Trigger warning about OMP_NUM_THREADS
    end
    
    App->>Common: Prepare input tensors
    Common->>Common: Process mixed type tensors
    Common-->>App: Return configured tensors

Loading

Possibly related PRs

• fix(lmp): update print_summary #4271: Changes related to error handling and library loading improvements across different platform configurations

Suggested labels

LAMMPS

Suggested reviewers

• wanghan-iapcm

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

source/api_cc/src/common.cc (1)

393-399: Consider storing the dlerror() output immediately in a local variable.
dlerror() returns a thread-local error message; if other dynamic loading calls or errors occur in parallel, the message could change before usage. Storing it in a local std::string right after dlopen() ensures the reported error is correct, even in multi-threaded contexts.

source/lib/src/gpu/cudart/cudart_stub.cc (1)

28-31: Validate or cache dlerror() before further calls.
dlerror() should be captured in a local variable immediately after dlopen() to ensure correctness in concurrent scenarios. Although it’s typically safe due to thread-local storage, capturing it right away is best practice.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c24498b and 40d2f54.

📒 Files selected for processing (2)

• source/api_cc/src/common.cc (1 hunks)
• source/lib/src/gpu/cudart/cudart_stub.cc (1 hunks)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.41%. Comparing base (c24498b) to head (40d2f54).
Report is 4 commits behind head on devel.

Files with missing lines	Patch %	Lines
source/api_cc/src/common.cc	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #4485      +/-   ##
==========================================
- Coverage   84.41%   84.41%   -0.01%     
==========================================
  Files         670      670              
  Lines       62149    62150       +1     
  Branches     3487     3487              
==========================================
- Hits        52465    52464       -1     
- Misses       8558     8559       +1     
- Partials     1126     1127       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.