-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc for spin data format #3762
Conversation
WalkthroughWalkthroughThe documentation update provides a comprehensive overview of the changes made to the data formats in TensorFlow and PyTorch/DP backends. It clarifies the distinctions between the two formats and offers a detailed explanation of the structure and content of the relevant data files for each backend, aiding users in understanding the requirements for effective model training. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional Context UsedLanguageTool (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Out of diff range and nitpick comments (3)
doc/model/train-energy-spin.md (3)
Line range hint
24-24
: Consider revising the phrase "each type of atoms" to "each type of atom" for grammatical correctness.
Line range hint
49-49
: Consider adding a comma after "flexible" for better readability and grammatical correctness.
Line range hint
96-104
: Replace hard tabs with spaces in the JSON examples to maintain consistency and improve readability in markdown files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (3)
doc/model/train-energy-spin.md (3)
Line range hint
24-24
: Correct grammatical agreement in the description.- type of atoms + types of atoms
Line range hint
49-49
: Consider adding a comma for clarity in the list of descriptors.- flexible and so far supports + flexible, and so far supports
Line range hint
96-104
: Replace hard tabs with spaces in JSON blocks for consistent formatting.- "type": "ener_spin", - "start_pref_e": 0.02, - "limit_pref_e": 1, - "start_pref_fr": 1000, - "limit_pref_fr": 1.0, - "start_pref_fm": 10000, - "limit_pref_fm": 10.0, - "start_pref_v": 0, - "limit_pref_v": 0, + "type": "ener_spin", + "start_pref_e": 0.02, + "limit_pref_e": 1, + "start_pref_fr": 1000, + "limit_pref_fr": 1.0, + "start_pref_fm": 10000, + "limit_pref_fm": 10.0, + "start_pref_v": 0, + "limit_pref_v": 0,
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3762 +/- ##
=======================================
Coverage 82.25% 82.25%
=======================================
Files 513 513
Lines 47666 47666
Branches 2981 2981
=======================================
Hits 39207 39207
Misses 7548 7548
Partials 911 911 ☔ View full report in Codecov by Sentry. |
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Updated documentation to clarify data format differences and detailed file structures for TensorFlow and PyTorch/DP backends. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Summary by CodeRabbit