Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support compressing any neuron structure #2933

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Oct 18, 2023

Fix #1370.

Support compressing any neuron structure; fix compression error when neuron[0] is 1 (although no one will set neuron[0] to 1).

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (64a5aa8) 72.47% compared to head (3fc74d3) 75.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #2933      +/-   ##
==========================================
+ Coverage   72.47%   75.19%   +2.71%     
==========================================
  Files         245      245              
  Lines       24687    24683       -4     
  Branches     1599     1599              
==========================================
+ Hits        17893    18561     +668     
+ Misses       5862     5186     -676     
- Partials      932      936       +4     
Files Coverage Δ
deepmd/descriptor/se_a.py 95.89% <ø> (+0.42%) ⬆️
deepmd/descriptor/se_atten.py 94.11% <ø> (+56.96%) ⬆️
deepmd/descriptor/se_r.py 95.70% <ø> (+0.36%) ⬆️
deepmd/descriptor/se_t.py 95.23% <ø> (+0.79%) ⬆️
deepmd/utils/tabulate.py 86.04% <100.00%> (+0.62%) ⬆️
source/op/unaggregated_grad.cc 67.51% <ø> (+2.54%) ⬆️

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz added the Test CUDA Trigger test CUDA workflow label Oct 18, 2023
@github-actions github-actions bot removed the Test CUDA Trigger test CUDA workflow label Oct 18, 2023
Copy link
Member

@denghuilu denghuilu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghan-iapcm wanghan-iapcm merged commit 299184c into deepmodeling:devel Oct 19, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Model compression fails for some descriptor neuron structures
3 participants