fix: prevent deepmd.tf be imported globally (#3382)

Add a ruff rule `TID253` to ensure it. --------- Signed-off-by: Jinzhe Zeng <[email protected]>
deepmodeling · Mar 2, 2024 · 831610a · 831610a
1 parent 92ee632
commit 831610a
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 31 deletions.
diff --git a/deepmd/utils/compat.py b/deepmd/utils/compat.py
@@ -16,7 +16,7 @@
 
 import numpy as np
 
-from deepmd.tf.common import (
+from deepmd.common import (
     j_must_have,
 )
 

diff --git a/doc/conf.py b/doc/conf.py
@@ -17,11 +17,9 @@
     date,
 )
 
-from deepmd.tf.common import (
+from deepmd.utils.argcheck import (
     ACTIVATION_FN_DICT,
     PRECISION_DICT,
-)
-from deepmd.tf.utils.argcheck import (
     list_to_doc,
 )
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -237,6 +237,7 @@ select = [
     "C4", # flake8-comprehensions
     "RUF", # ruff
     "NPY", # numpy
+    "TID253", # banned-module-level-imports
 ]
 
 ignore = [
@@ -256,9 +257,30 @@ ignore = [
 ]
 ignore-init-module-imports = true
 
+exclude = [
+    "source/3rdparty/**",
+]
+
 [tool.ruff.lint.pydocstyle]
 convention = "numpy"
 
+[tool.ruff.lint.flake8-tidy-imports]
+banned-module-level-imports = [
+    "deepmd.tf",
+    "deepmd.pt",
+    "tensorflow",
+    "torch",
+]
+
+[tool.ruff.lint.extend-per-file-ignores]
+# Also ignore `E402` in all `__init__.py` files.
+"deepmd/tf/**" = ["TID253"]
+"deepmd/pt/**" = ["TID253"]
+"source/tests/tf/**" = ["TID253"]
+"source/tests/pt/**" = ["TID253"]
+"source/ipi/tests/**" = ["TID253"]
+"source/lmp/tests/**" = ["TID253"]
+
 [tool.pytest.ini_options]
 markers = "run"
 

diff --git a/source/tests/common/test_uni_infer.py b/source/tests/common/test_uni_infer.py