Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Update and Refactor #76

Merged
merged 135 commits into from
Jul 24, 2024
Merged

SDK Update and Refactor #76

merged 135 commits into from
Jul 24, 2024

Conversation

DamienDeepgram
Copy link
Contributor

@DamienDeepgram DamienDeepgram commented Jul 17, 2024

Proposed changes

  • Add streaming features
  • Add support for pre-recorded features when streaming
  • Add Speech to Text
  • Refactor Code

Streaming Features

  • endpointing
  • utterance_end_ms
  • interim_results
  • no_delay
  • vad_events

Streaming Functions

  • keep_alive

New Streaming Message Types

  • Utterance End
  • Speech Started

Pre-Recorded Features

  • encoding
  • smart_format
  • callback
  • callback_method
  • filler_words
  • paragraphs
  • diarize_version
  • dictation
  • measurements
  • extra

Pre-Recorded Audio Intelligence Features

  • detect_entities
  • sentiment
  • topics
  • summarize
  • intents
  • custom_intents
  • custom_intent_mode
  • topics
  • custom_topics
  • custom_topic_mode

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING.md doc
  • I have added tests and/or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Also considered a different approach with a SerializeStreamingOptions and have the code still just in case but this followed existing patterns


examples/transcription/websocket/simple_stream.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/speak/options.rs Outdated Show resolved Hide resolved
src/manage/keys/options.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jcdyer jcdyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small requests. No need for a re-review.

examples/speak/rest/text_to_speech_to_file.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants