Skip to content

Commit

Permalink
code review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
deepanker13 committed Jan 4, 2024
1 parent cd811cd commit b8caae1
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions sdk/python/kubeflow/training/api/training_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
HfDatasetParams,
INIT_CONTAINER_MOUNT_PATH,
)
import os

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -101,10 +100,7 @@ def train(
model_provider_parameters: HuggingFaceModelParams = None,
dataset_provider_parameters: Union[HfDatasetParams, S3DatasetParams] = None,
train_parameters: HuggingFaceTrainParams = None,
resources_per_worker: Union[dict, client.V1ResourceRequirements, None] = {
"cpu": 1,
"memory": "2Gi",
},
resources_per_worker: Union[dict, client.V1ResourceRequirements, None] = None,
# Dict[Literal["gpu", "cpu", "memory"], any] = None,
):
"""
Expand Down

0 comments on commit b8caae1

Please sign in to comment.