Skip to content

Commit

Permalink
resolve merge conflict
Browse files Browse the repository at this point in the history
  • Loading branch information
deepanker13 committed Jan 4, 2024
1 parent d5ec8eb commit 8b7f276
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions sdk/python/kubeflow/storage_init_container/hugging_face.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class HuggingFaceModelParams:

def __post_init__(self):
# Custom checks or validations can be added here
if self.model_uri == "":
if self.model_uri == "" or self.model_uri is None:
raise ValueError("model_uri cannot be empty.")

@property
Expand Down Expand Up @@ -88,7 +88,7 @@ class HfDatasetParams:

def __post_init__(self):
# Custom checks or validations can be added here
if self.repo_id is None:
if self.repo_id == "" or self.repo_id is None:
raise ValueError("repo_id is None")

@property
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/kubeflow/storage_init_container/s3.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from abstract_dataset_provider import datasetProvider
from kubeflow.storage_init_container.abstract_dataset_provider import datasetProvider
from dataclasses import dataclass, field
import json, os
import boto3
Expand Down

0 comments on commit 8b7f276

Please sign in to comment.