cgo: Add verify message. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
force-pushed
the
verifymessage
branch
2 times, most recently
from
c7cb7fe
to
991e59c
Compare
JoeGruffins
commented
Oct 15, 2024
JoeGruffins
force-pushed
the
verifymessage
branch
from
991e59c
to
16b2e91
Compare
dreacot
reviewed
Oct 17, 2024
| return errCResponse("unable to decode signature: %v", err) | ||
| } | ||
|
|
||
| ok, err = dcrwallet.VerifyMessage(goString(cMessage), addr, sig, w.MainWallet().ChainParams()) |
There was a problem hiding this comment.
// Addresses must have an associated secp256k1 private key and therefore
// must be P2PK or P2PKH (P2SH is not allowed).
switch addr.(type) {
case *stdaddr.AddressPubKeyEcdsaSecp256k1V0:
case *stdaddr.AddressPubKeyHashEcdsaSecp256k1V0:
// Valid address types, proceed with verification.
default:
return errCResponse("invalid address type: must be P2PK or P2PKH")
}
shouldn't we be checking to ensure the address is not P2SH?
There was a problem hiding this comment.
Oh yeah. I assumed it would error somewhere along the way anyhow but we can check.
JoeGruffins
force-pushed
the
verifymessage
branch
from
16b2e91
to
71bb927
Compare
|
Added script type check and seed tweak https://github.com/decred/libwallet/compare/16b2e9192415c528b5afcf4fda227db76210b6fc..6fd12c60af251aa2b5c97b50e7a5d07078f4a74e |
JoeGruffins
force-pushed
the
verifymessage
branch
from
71bb927
to
6fd12c6
Compare
dreacot
approved these changes
Oct 18, 2024
dajohi
approved these changes
Oct 23, 2024
JoeGruffins
force-pushed
the
verifymessage
branch
from
6fd12c6
to
c890cb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.