-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OAuth2 token instead of server key for v1 #123
Use OAuth2 token instead of server key for v1 #123
Conversation
@erimicel thanks for doing this. Could you also look at the |
@sabman I've added a more detailed README. The core changes are listed below—could you review and let me know if they look sensible to you? The PR also has several styling issues flagged. Let me know if you think those need to be addressed. I performed a real production environment test with the given changes for each method, and all looks fine at the moment. Breaking Changes
Supported Features
We could leave the duplicated topic subscription methods in place and soft delete the api_key. However, if we release a new version, it might be a good opportunity for cleanup. But removing API_KEY will definitely break client initializers for everybody, so I am not sure. |
@AllanQ can we merge this? |
@sabman can we merge this? |
@tiendo1011, |
Just running tests will merge shortly. |
Thanks to all the awesome contributors! |
Added this PR thanks to @aap17 's change
#122 (comment)
Apps using the deprecated FCM legacy APIs for HTTP and XMPP should migrate to the HTTP v1 API at the earliest opportunity. Sending messages (including upstream messages) with those APIs was deprecated on June 20, 2023, and shutdown begins on July 22, 2024.
https://firebase.google.com/docs/cloud-messaging/migrate-v1
Before
Authorization: key=AIzaSyZ-1u...0GBYzPu7Udno5aA
After
Authorization: Bearer ya29.ElqKBGN2Ri_Uz...HnS_uNreA
This is already breaking change for sending messages via legacy api and should be removed;
Breaking Changes
API_KEY
send
methodsend_with_notification_key
methodsubscribe_instance_id_to_topic
methodunsubscribe_instance_id_from_topic
methodbatch_subscribe_instance_ids_to_topic
methodbatch_unsubscribe_instance_ids_from_topic
methodSupported Features
send_to_topic_condition
methodsend_to_topic
methodTODO