Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure protocolRole is maintained between query/read and subscribe/read. #954

Merged
merged 11 commits into from
Oct 21, 2024

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Oct 17, 2024

Before this PR that were some inconsistencies with using protocolRole.

There were instances where a user would query using a role but not be able to read the data of the given record because the role was not being applied. Same would happen during update/delete.

This PR allows the READ operation to inherit the protocolRole used for a query or subscribe if it exists.
Additionally it provides the user the ability to provide a different role when performing an update or delete operation.

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: ec3b2c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@web5/agent Patch
@web5/identity-agent Patch
@web5/proxy-agent Patch
@web5/user-agent Patch
@web5/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 17, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-10-21T13:46:32Z ec3b2c5

@LiranCohen LiranCohen force-pushed the lirancohen/fix-protocol-role-read branch from 1b3b05c to d7a6958 Compare October 17, 2024 21:27
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.35%. Comparing base (3f39bf1) to head (ec3b2c5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #954   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files         118      118           
  Lines       33714    33734   +20     
  Branches     2736     2740    +4     
=======================================
+ Hits        31473    31493   +20     
  Misses       2200     2200           
  Partials       41       41           
Components Coverage Δ
agent 87.81% <100.00%> (+<0.01%) ⬆️
api 99.61% <100.00%> (+<0.01%) ⬆️
common 95.02% <ø> (ø)
credentials 94.95% <ø> (ø)
crypto 93.79% <ø> (ø)
dids 97.77% <ø> (ø)
identity-agent 96.42% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.42% <ø> (ø)
user-agent 96.57% <ø> (ø)

@LiranCohen LiranCohen marked this pull request as ready for review October 18, 2024 23:57
csuwildcat
csuwildcat previously approved these changes Oct 19, 2024
@LiranCohen LiranCohen merged commit 5120f6f into main Oct 21, 2024
35 checks passed
@LiranCohen LiranCohen deleted the lirancohen/fix-protocol-role-read branch October 21, 2024 14:49
This was referenced Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants