-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for Reading public Records/Protocols when in a delegated state #899
Conversation
…icit permissions when in a delegated state
🦋 Changeset detectedLatest commit: b40a843 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-09-11T16:55:55Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 117 117
Lines 33363 33408 +45
Branches 2693 2697 +4
=======================================
+ Hits 31178 31223 +45
Misses 2146 2146
Partials 39 39
|
When in a delegated state, allow the user to read/query/subscribe to public records and protocols even if they don't have an explicit permission for them.
These query/read/subscribe messages will be AUTHORED by the Delegated DID instead of the Connected DID.
If attempting to update/import/etc these records they will fail due to lack of permissions.
Ultimately read-only actions would be moved to a different part of the API, reverting much of this code:
#898
Resolved vulnerability issues with
pnpm audit --fix