Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for publishing NS records + official test vector 2 compliance #514

Merged
merged 6 commits into from
May 7, 2024

Conversation

thehenrytsai
Copy link
Contributor

@thehenrytsai thehenrytsai commented May 6, 2024

  1. Added support for publishing NS records and fixed bugs to achieve official test vector 2 compliance.
  2. Removed kid in DNS records according to DID DHT spec update.
  3. Minor renaming.
  4. QoL - Updated CODEOWNERS to further increase review efficiency.
  5. QoL - Added HTML code coverage output for dids repo for immediate coverage feedback.

Copy link

changeset-bot bot commented May 6, 2024

⚠️ No Changeset found

Latest commit: d2d495c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 6, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-05-06T21:49:28Z d2d495c

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 95.38462% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.83%. Comparing base (1d59f71) to head (d2d495c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
+ Coverage   90.81%   90.83%   +0.01%     
==========================================
  Files         116      116              
  Lines       29442    29478      +36     
  Branches     2156     2159       +3     
==========================================
+ Hits        26739    26776      +37     
+ Misses       2668     2667       -1     
  Partials       35       35              
Components Coverage Δ
agent 79.90% <ø> (ø)
api 97.92% <ø> (ø)
common 98.68% <ø> (ø)
credentials 95.26% <ø> (ø)
crypto 93.81% <ø> (ø)
dids 97.69% <95.38%> (+0.03%) ⬆️
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

Copy link
Contributor

@nitro-neal nitro-neal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dude great job!
One last piece of this is coming soon right? the fromDnsPacket() part?

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thehenrytsai thehenrytsai merged commit 6c57350 into main May 7, 2024
11 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/dids-vector-2 branch May 7, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants