Allow for setting custom Verification Method IDs #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2024 21:54
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 51.59% 51.91% +0.32%
==========================================
Files 32 32
Lines 2791 2816 +25
==========================================
+ Hits 1440 1462 +22
- Misses 1205 1207 +2
- Partials 146 147 +1 ☔ View full report in Codecov by Sentry. |
decentralgabe
requested review from
mistermoe,
finn-block,
csuwildcat and
frankhinek
as code owners
decentralgabe
commented
May 23, 2024
| @@ -337,18 +338,25 @@ as a `_kN._did.` record where `N` is the zero-indexed positional index of a give | |||
| indicating a Text record. | |||
|
|
|||
| - Each [Verification Method](https://www.w3.org/TR/did-core/#verification-methods) record's **rdata** is represented by the form | |||
There was a problem hiding this comment.
interesting bits here
decentralgabe
commented
May 23, 2024
| @@ -538,14 +548,19 @@ To read a `did:dht` document, the process is as follows: | |||
|
|
|||
| 2. Decode the resulting [[ref:BEP44]] response's `v` value using [[ref:bencode]]. | |||
|
|
|||
| 3. Uncompress the DNS packet according to [[spec:RFC1035]] section 4.1.4. | |||
| 3. Uncompress the DNS packet according to [[spec:RFC1035]] [section 4.1.4](https://datatracker.ietf.org/doc/html/rfc1035#section-4.1.4). | |||
|
|
|||
| 4. Reverse the DNS [property mapping](#property-mapping) process and re-construct a conformant [[ref:DID Document]]. | |||
|
|
|||
| a. Identify the [[ref:Identity Key]] using the [[ref:suffix]] of the `did:dht` identifier, with record name `_k0._did`, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #224
Also: