Cleanup empty scenes build #6176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProteanCoding
changed the title
ProteanCoding
commented
Apr 18, 2024
| @@ -46,7 +46,7 @@ node_modules/ | |||
| npm-debug.log | |||
| .DS_Store | |||
| static/dist | |||
| public/systems | |||
There was a problem hiding this comment.
This folder is no longer present
|
How are you testing those changes? You would need to provide a bit more context why are you proposing this change |
|
This is meant as a follow-up to #6175. |
ProteanCoding
commented
Apr 19, 2024
| @@ -46,7 +46,7 @@ node_modules/ | |||
| npm-debug.log | |||
| .DS_Store | |||
| static/dist | |||
| public/systems | |||
| public/empty-scenes/common/contents | |||
There was a problem hiding this comment.
This ends up containing what are in fact temporary build files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Removal from the repository of the temporary Empty Scenes build files.