feat: Sequential emotes #5771
Draft
feat: Sequential emotes #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes: WebThis branch can be previewed at:
Desktop:If you have the launcher installed (download launcher) you can press open on the following link: SDK 6/7:More |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Added sequential emotes support
How to test the changes?
https://play.decentraland.zone/?BUILDER_SERVER_URL=https://builder-api.decentraland.zone/v1&NETWORK=sepolia&DEBUG_MODE=true&WITH_COLLECTIONS=9ea65056-3e0a-4093-a61a-f1760ee3c710&position=100,100&explorer-branch=feat/sequential-emotes
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
🤖 Generated by Copilot at 1c6adf7
This pull request refactors the EmotesService domain layer and related classes to support sequential emotes, which are emotes that consist of multiple animation clips. It introduces a new type called
EmoteAnimationDatathat replaces the oldEmoteClipDatatype, and a new struct calledAnimationSequencethat represents the sequence of clips for an emote. It also updates theIEmoteReference,IEmoteAnimationLoader, andIAnimatorinterfaces, and theEmbedEmoteReference,NftEmoteReference,EmoteAnimationLoader,EmotesService,AvatarAnimatorLegacy,DCLCharacterController,AvatarEmotesController, andEmotesCustomizationComponentControllerclasses to use the new types and logic. It also fixes a circular dependency issue in theEmotesServiceDefinitions.asmdeffile, and adds a debug log statement in theAsyncEmoteLoadmethod.