Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add network inspector #477

Merged
merged 4 commits into from
Nov 1, 2024
Merged

feat: add network inspector #477

merged 4 commits into from
Nov 1, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Oct 31, 2024 •
edited
Loading

Add the network inspector. When it enables, the requester sends a report with the info when the request inits, then an update when finishes well or not.

Also:

  • remove HttpRequester (the one is not Queue) and their tests
  • adapt SceneEntityCoordinator to use HttpQueueRequester
  • Remove make string header key: value and use HashMap instead

kuruk-mm
kuruk-mm approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@kuruk-mm kuruk-mm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just a quick polish review.

lib/src/http_request/rust_http_queue_requester.rs Outdated Show resolved Hide resolved
lib/src/tools/network_inspector.rs Outdated Show resolved Hide resolved
godot/src/global.gd Show resolved Hide resolved
godot/src/global.gd Show resolved Hide resolved
lib/src/http_request/rust_http_queue_requester.rs Show resolved Hide resolved
lib/src/realm/scene_entity_coordinator.rs Show resolved Hide resolved
lib/src/realm/scene_entity_coordinator.rs Show resolved Hide resolved
@leanmendoza leanmendoza merged commit 6439aaf into main Nov 1, 2024
7 checks passed
@leanmendoza leanmendoza deleted the feat/add-network-inspector branch November 1, 2024 09:08
@kuruk-mm kuruk-mm added this to the Scene Tools for Creators milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuruk-mm kuruk-mm kuruk-mm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Scene Tools for Creators
Development

Successfully merging this pull request may close these issues.
2 participants
@leanmendoza @kuruk-mm