docs: ADR-202 for linked wearables v2 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying adr with
|
| Latest commit: |
6258744
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6ddcd45d.adr-cvq.pages.dev |
| Branch Preview URL: | https://linked-wearables.adr-cvq.pages.dev |
marianogoldman
approved these changes
Aug 21, 2024
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: pentreathm <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: pentreathm <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: pentreathm <[email protected]>
Signed-off-by: pentreathm <[email protected]>
|
|
||
| ## Decision | ||
|
|
||
| LinkedWearables in Decentraland are wearables exclusively granted to owners of specific NFTs. While the wearables themselves cannot be traded, the underlying NFTs can. Verifying ownership of these wearables necessitated a third-party API. To streamline this process, a new system of URNs for LinkedWearables and wearable metadata will be introduced. These URNs and metadata will comprehensively describe both the Decentraland wearable and its corresponding NFT, enabling on-chain verification of NFT ownership, thereby eliminating the reliance on third party APIs. |
There was a problem hiding this comment.
Verifying ownership of these wearables necessitated a third-party API. -> Verifying ownership of these wearables necessitated a service to provide the owner of the represented NFTs.
| The examples below are mapping configurations within a wearable entity that represent various use cases. This information is sent to the Catalyst during the deployment of the wearable entity. | ||
|
|
||
| - **Owns a specific NFT collection item**: the user owning the item with id `1` in the NFT collection `0x1234567890abcdef1234567890abcdef12345678` on `matic` will be granted with this wearable | ||
| ```code:json |
There was a problem hiding this comment.
remove code:json cause this block is hidden here
|
|
||
| ### Third Party Registry | ||
|
|
||
| When a third party is registered, a record is added to the third party's smart contract. This record must now include the list of NFT collection contracts and their corresponding chains for which the third party will create wearables. This information is essential for the Catalyst nodes to create a backpack endpoint, retrieve all NFTs owned by a wallet across those collections, and identify any corresponding linked wearables for those NFT items. |
There was a problem hiding this comment.
Can we add an example?
There was a problem hiding this comment.
It should be
tp:version:lw-name:lw-description:lw-collections
E.g: tp:1:third-party-test:this-is-a-description:sepolia-0x74c78f5A4ab22F01d5fd08455cf0Ff5C3367535C;amoy-0x31c78f3A4ac21F41e5ad28345df1Fa5A3367213A
|
|
||
| ## Consequences | ||
|
|
||
| - Third parties will no longer need to pay for the development and maintenance of an API to verify NFT ownership and the associated wearables. |
There was a problem hiding this comment.
Third parties will no longer need to pay for the development and maintenance of an API to verify NFT ownership and the associated wearables.
to
Third parties will no longer need to develop and maintain an API to verify NFT ownership and the associated Decentraland wearables.
| - Third parties will no longer need to pay for the development and maintenance of an API to verify NFT ownership and the associated wearables. | ||
| - Retrieving a profile or batch of profiles from the Catalyst node will no longer be affected by slow third-party resolvers. | ||
| - Old third-party wearables need to be updated by the third parties to include the mapping information, or after the deadline, they will stop working, and their NFT holders won't be able to retrieve their wearables. | ||
| - There is a dependency on the Alchemy API or similar third-party services to query which NFT items a user owns from a collection. - Only the chains supported by these services can be used. This dependency could be replaced or expanded to add support for more chains as they become available in the market. |
There was a problem hiding this comment.
There is a dependency on the Alchemy API or similar third-party services to query which NFT items a user owns from a collection. - Only the chains supported by these services can be used. This dependency could be replaced or expanded to add support for more chains as they become available in the market.
to
For this iteration, the service to validate NFT ownership will be a thirdparty API. Only the chains supported by these services can be used. This service can be replaced or expanded to support more chains as they become available in the market.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.