Skip to content

Commit

Permalink
.github/workflows: Remove golangci-lint
Browse files Browse the repository at this point in the history
The previous commit broke the golangci-lint test [1] because the GitHub
Action runs on Ubuntu 22.04, which only has Shadow 4.8 [2], whereas
libsubid.so was introduced in Shadow 4.9 [3].

However, that's not a big deal because 'go vet' was earlier added to the
set of tests run by 'meson test' [4], and 'go vet' is one of the linters
run by golangci-lint [5].  So, while it's not a proper replacement, it's
good enough.

[1] Commit ca8007c
    containers#1180

[2] https://packages.ubuntu.com/source/jammy/shadow
    https://packages.ubuntu.com/source/jammy-updates/shadow

[3] Shadow commit 0a7888b1fad613a0
    shadow-maint/shadow@0a7888b1fad613a0
    shadow-maint/shadow#154

[4] Commit f695012
    containers#1186

[5] https://golangci-lint.run/usage/linters/
    https://golangci-lint.run/usage/linters/#govet

This reverts commit 7c86f30.
  • Loading branch information
debarshiray committed Jan 29, 2023
1 parent ca8007c commit 3d1a123
Showing 1 changed file with 0 additions and 24 deletions.
24 changes: 0 additions & 24 deletions .github/workflows/linting.yaml

This file was deleted.

0 comments on commit 3d1a123

Please sign in to comment.