CI now covers compilation of all projects. #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfehling
force-pushed
the
xbraid
branch
2 times, most recently
from
ef96082
to
033905b
Compare
|
In later patches, we might want to
|
Comment on lines
53
to
-68
| FIND_PATH(BRAID_INCLUDE_DIR | ||
| NAMES braid.h | ||
| HINTS ${BRAID_DIR} | ||
| PATH_SUFFIXES include | ||
| ) | ||
|
|
||
| FIND_LIBRARY(BRAID_LIBRARY | ||
| NAMES braid.a | ||
| NAMES libbraid.a | ||
| HINTS ${BRAID_DIR} | ||
| PATH_SUFFIXES lib64 lib |
There was a problem hiding this comment.
Normally, you would install xbraid instead of just building it, right? I think we should do that in the CI, too.
There was a problem hiding this comment.
xbraid is such a homegrown project that it is built with a small Makefile and no install target :-)
There was a problem hiding this comment.
There is no convenient way to install it using their Makefile. Building is also the option they provide in their user manual.
https://github.com/XBraid/xbraid/files/10865642/user_manual.pdf
https://github.com/XBraid/xbraid/blob/master/braid/Makefile
masterleinad
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dealii/dealii#15073.
I believe this is the most convenient and low-maintenance way to verify that all code-gallery programs compile.
CeresFEcouldn't be compiled with deal.II 9.4 because of a deprecated function that has been deleted. I've updated it in this patch so that the CI will pass.parallel_in_timefinds the braid include folder, but has issues finding the actual library. I've changed a few lines in itsCMakeLists.txt.