-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LXC Container support #53
base: current-dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I feel that this PR is definitely aligned with the scope of the project as it literally makes it possible installing it on a wider range of machines and configurations. This said - I have some questions and concerns that need to be addressed first.
(Also, do you by any chance know or tried to test this on Docker as well? Given that I feel some folks may have stopped by asking for this before).
Regardless, thanks for this awesome work!
Okay I'll try to make this more generic and look into autodetection. Never used docker sorry. I figured if they were running in a container they're more likely to be a power user anyway. The bug is described in the commit. Basically if you have a zone domain.com and a domain domain.com and your miab box is called miab.domain.com, the logic means the miab host name will be overwritten in the else clause due to the domain sort order and there being no leading dot in domain.com. |
Ran into a problem with docker due to this error:
Described here: We're probably 90% of the way there though |
I think this is worth another look now and a test if possible. A few additional tweaks:
|
Have changed the System status checks to look like this. If the service is running it's a warning, only if it isn't running at all is it an error. The first line is only displayed for an LXC container: System? The following checks try to connect to each service on your public IP, which may not work on your platform type.
|
Any news on this? |
There are still a few broken admin page links if the HTTPS port number is changed from 443. I'll fix if you're going to merge. |
…o included in list of domains because of sort order and no preceding dot in zone name
…ion, fix defaults logic
ea9da31
to
003c96c
Compare
@ddavness I've rebased onto your latest changes. Are there any more issues with this? |
I'll review this later - as you can understand this is quite a bit of a change, so I'll take a further deep dive on it when I have a proper chunk of time :) |
LXC Container support with a few other fixes:
Needs more testing on existing installs - mine's fresh