Fixes to get PDT working. #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 23, 2011 03:58
…PDT which won't store new pdt objects to the DB if they have invalid forms/postback responses, and 2) copy the txn_id over from the pdt GET method's tx parameter. This just makes invalid objects look better in the admin interface. (formerly they showed up as PDT: recurring since they didn't have a txn_id)
… explain the setting
…d @require_GET decorator, since paypal is POSTing PDT data as of 09/23/2011
|
|
||
| if not invalid_paypal_obj or \ | ||
| not hasattr(settings, 'IGNORE_INVALID_PDT') or \ | ||
| not settings.IGNORE_INVALID_PDT: |
There was a problem hiding this comment.
Why not simply if not invalid_paypal_obj or getattr(settings, 'IGNORE_INVALID_PDT', False)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing PDT to handle POST requests from paypal, more graceful error handling, and a security fix.
Tested on both sandbox and live Paypal servers.