-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuzz: distinguish between reading/writing properties in logs #88
Conversation
Also, reorder the for/loop statements, because I have no idea why I put them like I did in the first place, and check if the remote side is alive even after just reading a property. ``` Interface: org.freedesktop.dfuzzerInterface PASS [P] read_only (read) PASS [P] write_only (write) FAIL [P] crash_on_write (write) - unexpected response while writing to a property [RE-CONNECTED TO PID: 2479535] PASS [P] read_write (read) PASS [P] read_write (write) PASS [M] df_hello ... ``` Addresses: https://github.com/matusmarhefka/dfuzzer/pull/86#pullrequestreview-971808731
Also a note - there's something wrong with the ppc Copr builders, so the ppc Packit jobs currently end up stuck in the queue indefinitely (so there's no point on waiting for them to finish). |
https://github.com/matusmarhefka/dfuzzer/pull/65 was based on the assumption that it's possible to provide a one-size-fits-all config file but at this point I'm not sure if it makes sense. For example, https://github.com/matusmarhefka/dfuzzer/issues/67 is different in the sense that it should probably be addressed somehow but the only user relying on the output of All in all, I think those issues can be addressed later. If it tagging a release could help to finally switch to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Also, reorder the for/loop statements, because I have no idea why I put
them like I did in the first place, and check if the remote side is
alive even after just reading a property.
Addresses: https://github.com/matusmarhefka/dfuzzer/pull/86#pullrequestreview-971808731