Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate Azure DevOps Project Datasource from SDKv2 to the plugin framework #321

Merged

Conversation

csquire
Copy link
Contributor

@csquire csquire commented Dec 6, 2024

Migrates the dbtcloud_azure_dev_ops_project datasource from the legacy SDKv2 to the Terraform Plugin Framework.

@csquire csquire requested a review from chasewalden December 6, 2024 16:11
Copy link
Collaborator

@b-per b-per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks that there was no test for the SDKv2 datasource, but would it make sense to add a test of the new datasource that we would run only in Dev (I don't think that we would be able to test in CI as we might not have an ADO integration in place)

@chasewalden
Copy link
Collaborator

It looks that there was no test for the SDKv2 datasource, but would it make sense to add a test of the new datasource that we would run only in Dev (I don't think that we would be able to test in CI as we might not have an ADO integration in place)

I think that's the challenge. We're getting other team members ramped in the codebase, and since there were no tests, it might be tricky to retroactively add in tests, especially if there's not ADO integration available. We have a ticket to add further testing where there seem to be gaps

@chasewalden
Copy link
Collaborator

@b-per , I'm going to get this merged to keep the rest of the team on track. I will add acc tests separately

@chasewalden chasewalden merged commit 16b5033 into dbt-labs:main Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants